SSL: disabled sending shutdown after ngx_http_test_reading(). Sending shutdown when ngx_http_test_reading() detects the connection is closed can result in "SSL_shutdown() failed (SSL: ... bad write retry)" critical log messages if there are blocked writes. Fix is to avoid sending shutdown via the c->ssl->no_send_shutdown flag, similarly to how it is done in ngx_http_keepalive_handler() for kqueue when pending EOF is detected. Reported by Jan PrachaĆ (http://mailman.nginx.org/pipermail/nginx-devel/2018-December/011702.html).
diff --git a/src/http/ngx_http_request.c b/src/http/ngx_http_request.c index 257c406..f80785d 100644 --- a/src/http/ngx_http_request.c +++ b/src/http/ngx_http_request.c
@@ -2992,6 +2992,12 @@ rev->error = 1; } +#if (NGX_HTTP_SSL) + if (c->ssl) { + c->ssl->no_send_shutdown = 1; + } +#endif + ngx_log_error(NGX_LOG_INFO, c->log, err, "client prematurely closed connection");