commit f0cec81a7260c47031872ed55fe6a1759a3cf1c2
author Maxim Dounin <mdounin@mdounin.ru> Tue Sep 29 15:54:09 2020 +0300
committer Maxim Dounin <mdounin@mdounin.ru> Tue Sep 29 15:54:09 2020 +0300
tree 1981eaf5fcdee314fbbb725951da8a489d060b82
parent b63b9b0dea90444ca58e748dc5c12c15f36c3164

Proxy: error checking for array init, missed in 7716:d6a5e14aa3e4.

Found by Coverity (CID 1467637).

src/http/modules/ngx_http_proxy_module.c

diff --git a/src/http/modules/ngx_http_proxy_module.c b/src/http/modules/ngx_http_proxy_module.c
index 17e4761..c5c9e85 100644
--- a/src/http/modules/ngx_http_proxy_module.c
+++ b/src/http/modules/ngx_http_proxy_module.c
@@ -2679,7 +2679,9 @@
     ngx_keyval_t               *attr;
     ngx_http_proxy_loc_conf_t  *plcf;
 
-    ngx_array_init(&attrs, r->pool, 2, sizeof(ngx_keyval_t));
+    if (ngx_array_init(&attrs, r->pool, 2, sizeof(ngx_keyval_t)) != NGX_OK) {
+        return NGX_ERROR;
+    }
 
     if (ngx_http_proxy_parse_cookie(&h->value, &attrs) != NGX_OK) {
         return NGX_ERROR;