commit d3ceee5268c2f925ee97e3627b9859abe7559603
author Maxim Dounin <mdounin@mdounin.ru> Fri Mar 05 17:16:15 2021 +0300
committer Maxim Dounin <mdounin@mdounin.ru> Fri Mar 05 17:16:15 2021 +0300
tree 859901108dc39b8c4f5b123c4e2443928bd50433
parent 8d894a24c1232a33f0b6317d86a0c8d9b7873e2a

Events: fixed eventport handling in ngx_handle_read_event().

The "!rev->ready" test seems to be a typo, introduced in the original
commit (719:f30b1a75fd3b).  The ngx_handle_write_event() code properly
tests for "rev->ready" instead.

Due to this typo, read events might be unexpectedly removed during
proxying after an event on the other part of the proxied connection.
Catched by mail proxying tests.

src/event/ngx_event.c

diff --git a/src/event/ngx_event.c b/src/event/ngx_event.c
index 402a7f5..ed7b30b 100644
--- a/src/event/ngx_event.c
+++ b/src/event/ngx_event.c
@@ -318,7 +318,7 @@
             return NGX_OK;
         }
 
-        if (rev->oneshot && !rev->ready) {
+        if (rev->oneshot && rev->ready) {
             if (ngx_del_event(rev, NGX_READ_EVENT, 0) == NGX_ERROR) {
                 return NGX_ERROR;
             }