commit 45075adccf8f5f88db0ee59c14282d187c5c58ea
author Maxim Dounin <mdounin@mdounin.ru> Thu Oct 31 04:16:20 2013 +0400
committer Maxim Dounin <mdounin@mdounin.ru> Thu Oct 31 04:16:20 2013 +0400
tree 03b568b4a8cf568c5c2081232124733acaa75e0b
parent eea2e1262b204c75996ba38f4d0fd9d8f9930948

Gunzip: proper error handling on gunzipping an empty response.

With previous code, an empty (malformed) response resulted in a request
finalized without sending anything to a client.

src/http/modules/ngx_http_gunzip_filter_module.c

diff --git a/src/http/modules/ngx_http_gunzip_filter_module.c b/src/http/modules/ngx_http_gunzip_filter_module.c
index 9a1ce41..adadc9d 100644
--- a/src/http/modules/ngx_http_gunzip_filter_module.c
+++ b/src/http/modules/ngx_http_gunzip_filter_module.c
@@ -500,9 +500,13 @@
         return NGX_OK;
     }
 
-    if (rc == Z_STREAM_END && ctx->flush == Z_FINISH
-        && ctx->zstream.avail_in == 0)
-    {
+    if (ctx->flush == Z_FINISH && ctx->zstream.avail_in == 0) {
+
+        if (rc != Z_STREAM_END) {
+            ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,
+                          "inflate() returned %d on response end", rc);
+            return NGX_ERROR;
+        }
 
         if (ngx_http_gunzip_filter_inflate_end(r, ctx) != NGX_OK) {
             return NGX_ERROR;