tree 27f6d2a3fb5e068ba1f3ef2de9a15d89c735c27d
parent 36937c36ceb5f5ac0fe5db1451e63660e1967dd4
author Ruslan Ermilov <ru@nginx.com> 1497433760 +0300
committer Ruslan Ermilov <ru@nginx.com> 1497433760 +0300

Gzip: fixed style in $gzip_ratio variable handler.

The current style in variable handlers returning NGX_OK is to either set
v->not_found to 1, or to initialize the entire ngx_http_variable_value_t
structure.

In theory, always setting v->valid = 1 for NGX_OK would be useful, which
would mean that the value was computed and is thus valid, including the
special case of v->not_found = 1.  But currently that's not the case and
causes the (v->valid || v->not_found) check to access an uninitialized
v->valid value, which is safe only because its value doesn't matter when
v->not_found is set.