commit | cd08515bd0f542c62afaac563d3eb86ae839f496 | [log] [tgz] |
---|---|---|
author | Piotr Sikora <piotrsikora@google.com> | Wed Apr 05 23:36:06 2017 -0700 |
committer | Piotr Sikora <piotrsikora@google.com> | Wed Apr 19 21:03:41 2017 +0000 |
tree | efa4bf21eecf7ce6c94b6b7eec5c37bbe30a365f | |
parent | c5e3875337ffab7b2cafd828d4204e84da06769b [diff] |
HTTP/2: don't send SETTINGS ACK before already queued DATA frames. Previously, SETTINGS ACK was sent immediately upon receipt of SETTINGS frame, before already queued DATA frames created using "old" SETTINGS. This incorrect behavior was source of interoperability issues, because peers rely on a fact that "new" SETTINGS are in effect after receiving SETTINGS ACK. Change-Id: If74c677658b1cf41d63d91ffb51b030a118fe793 Signed-off-by: Piotr Sikora <piotrsikora@google.com> Reviewed-on: https://nginx-review.googlesource.com/2924 Reviewed-by: Feng Li <fengli@google.com> Reviewed-by: Lizan Zhou <zlizan@google.com>
To build nginx
binary with Bazel:
$ bazel build :nginx
To build Debian package:
$ bazel build :nginx-google.deb
This repository is currently maintained by Google developers.
Any code changes should be submitted to upstream NGINX.
Copyright (C) 2002-2017 Igor Sysoev Copyright (C) 2011-2017 Nginx, Inc. Copyright (C) 2015-2017 Google Inc. All rights reserved. Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: 1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. 2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
This is not an official Google product.