commit bdfb5a93461b727f51bdaf00915445cbb59e84cc
author Roman Arutyunyan <arut@nginx.com> Thu Sep 01 14:33:51 2016 +0300
committer Roman Arutyunyan <arut@nginx.com> Thu Sep 01 14:33:51 2016 +0300
tree 3da59103d529c7ef8c93e68d98d37a36309f5550
parent e09a2ef6f564efa66baa58d0c9d755d5646e09d6

Realip: fixed uninitialized memory access.

Previously, the realip module could be left with uninitialized context after an
error in the ngx_http_realip_set_addr() function.  That context could be later
accessed by $realip_remote_addr and $realip_remote_port variable handlers.

src/http/modules/ngx_http_realip_module.c

diff --git a/src/http/modules/ngx_http_realip_module.c b/src/http/modules/ngx_http_realip_module.c
index 490a53d..dba3c52 100644
--- a/src/http/modules/ngx_http_realip_module.c
+++ b/src/http/modules/ngx_http_realip_module.c
@@ -264,7 +264,6 @@
     }
 
     ctx = cln->data;
-    ngx_http_set_ctx(r, ctx, ngx_http_realip_module);
 
     c = r->connection;
 
@@ -282,6 +281,7 @@
     ngx_memcpy(p, text, len);
 
     cln->handler = ngx_http_realip_cleanup;
+    ngx_http_set_ctx(r, ctx, ngx_http_realip_module);
 
     ctx->connection = c;
     ctx->sockaddr = c->sockaddr;