commit ad6e846ad0fa2392889ce62ff7726175df0eabe6
author Ruslan Ermilov <ru@nginx.com> Tue Jan 30 14:44:31 2018 +0300
committer Ruslan Ermilov <ru@nginx.com> Tue Jan 30 14:44:31 2018 +0300
tree 86d396c2dac0c03b4b3cd85489cdd7022a9f4532
parent 1c8aac2ce5492f01d45e249f25ea0f2ac8546043

HTTP/2: finalize request as bad if parsing of pseudo-headers fails.

This is in line when the required pseudo-headers are missing, and
avoids spurious zero statuses in access.log.

src/http/v2/ngx_http_v2.c

diff --git a/src/http/v2/ngx_http_v2.c b/src/http/v2/ngx_http_v2.c
index 8507eac..8c752db 100644
--- a/src/http/v2/ngx_http_v2.c
+++ b/src/http/v2/ngx_http_v2.c
@@ -1583,14 +1583,7 @@
         }
 
         if (rc == NGX_DECLINED) {
-            if (ngx_http_v2_terminate_stream(h2c, h2c->state.stream,
-                                             NGX_HTTP_V2_PROTOCOL_ERROR)
-                == NGX_ERROR)
-            {
-                return ngx_http_v2_connection_error(h2c,
-                                                    NGX_HTTP_V2_INTERNAL_ERROR);
-            }
-
+            ngx_http_finalize_request(r, NGX_HTTP_BAD_REQUEST);
             goto error;
         }