commit ac31ad54d9acecd986989de190610be5da2f9f6f
author Piotr Sikora <piotrsikora@google.com> Mon Aug 15 05:52:04 2016 -0700
committer Piotr Sikora <piotrsikora@google.com> Mon Aug 15 05:52:04 2016 -0700
tree d84b305fbfc330e640125d0927a323a4ded6b78c
parent 1283ca521e3c83edddc37f66a03c17ba8d01f858

Thread pools: create threads in detached state.

This prevents theoretical resource leak, since those threads are never joined.

Found with ThreadSanitizer.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

src/core/ngx_thread_pool.c

diff --git a/src/core/ngx_thread_pool.c b/src/core/ngx_thread_pool.c
index f3655aa..7fb0f7f 100644
--- a/src/core/ngx_thread_pool.c
+++ b/src/core/ngx_thread_pool.c
@@ -137,6 +137,13 @@
         return NGX_ERROR;
     }
 
+    err = pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
+    if (err) {
+        ngx_log_error(NGX_LOG_ALERT, log, err,
+                      "pthread_attr_setdetachstate() failed");
+        return NGX_ERROR;
+    }
+
 #if 0
     err = pthread_attr_setstacksize(&attr, PTHREAD_STACK_MIN);
     if (err) {