commit 7b24c53efee348e919d03cba5c74445095402593
author Yichun Zhang <agentzh@gmail.com> Fri Jul 25 14:43:29 2014 -0700
committer Yichun Zhang <agentzh@gmail.com> Fri Jul 25 14:43:29 2014 -0700
tree 25f46a0eff22adee73b56191bef6a8fd74f07407
parent 3ba8f2f73d27af3cd56506922edd91db2a56eb03

GeoIP: not all variable fields were initialized.

The ngx_http_geoip_city_float_variable and
ngx_http_geoip_city_int_variable functions did not always initialize
all variable fields like "not_found", which could lead to empty values
for those corresponding nginx variables randomly.

src/http/modules/ngx_http_geoip_module.c

diff --git a/src/http/modules/ngx_http_geoip_module.c b/src/http/modules/ngx_http_geoip_module.c
index 1af166e..8e151aa 100644
--- a/src/http/modules/ngx_http_geoip_module.c
+++ b/src/http/modules/ngx_http_geoip_module.c
@@ -553,6 +553,9 @@
     val = *(float *) ((char *) gr + data);
 
     v->len = ngx_sprintf(v->data, "%.4f", val) - v->data;
+    v->valid = 1;
+    v->no_cacheable = 0;
+    v->not_found = 0;
 
     GeoIPRecord_delete(gr);
 
@@ -582,6 +585,9 @@
     val = *(int *) ((char *) gr + data);
 
     v->len = ngx_sprintf(v->data, "%d", val) - v->data;
+    v->valid = 1;
+    v->no_cacheable = 0;
+    v->not_found = 0;
 
     GeoIPRecord_delete(gr);