commit 5867c81fe6c9485937fe87c43634cdaab29b483b
author Maxim Dounin <mdounin@mdounin.ru> Wed Sep 05 15:06:47 2012 +0000
committer Maxim Dounin <mdounin@mdounin.ru> Wed Sep 05 15:06:47 2012 +0000
tree 1d7477d316284d8e2e4e9293e9b919022cd1d889
parent 605a0ab2e1bbaba36e3d275e22b066238f87b4cb

Write filter: replaced unneeded loop with one to free chains.

Noted by Gabor Lekeny.

src/http/ngx_http_write_filter_module.c

diff --git a/src/http/ngx_http_write_filter_module.c b/src/http/ngx_http_write_filter_module.c
index 72b1f9b..fd44bc6 100644
--- a/src/http/ngx_http_write_filter_module.c
+++ b/src/http/ngx_http_write_filter_module.c
@@ -185,23 +185,19 @@
     }
 
     if (size == 0 && !(c->buffered & NGX_LOWLEVEL_BUFFERED)) {
-        if (last) {
+        if (last || flush) {
+            for (cl = r->out; cl; /* void */) {
+                ln = cl;
+                cl = cl->next;
+                ngx_free_chain(r->pool, ln);
+            }
+
             r->out = NULL;
             c->buffered &= ~NGX_HTTP_WRITE_BUFFERED;
 
             return NGX_OK;
         }
 
-        if (flush) {
-            do {
-                r->out = r->out->next;
-            } while (r->out);
-
-            c->buffered &= ~NGX_HTTP_WRITE_BUFFERED;
-
-            return NGX_OK;
-        }
-
         ngx_log_error(NGX_LOG_ALERT, c->log, 0,
                       "the http output chain is empty");