)]}'
{
  "commit": "4d479d23ee5b91d0cd4fd5a9c15fe99b053b6f4e",
  "tree": "a907486dd178630e8707994de5554d1f5ad64a4c",
  "parents": [
    "04753bfe00f5d4442a23fffbbd4b545095b44f87"
  ],
  "author": {
    "name": "Maxim Dounin",
    "email": "mdounin@mdounin.ru",
    "time": "Mon Feb 25 16:41:15 2019 +0300"
  },
  "committer": {
    "name": "Maxim Dounin",
    "email": "mdounin@mdounin.ru",
    "time": "Mon Feb 25 16:41:15 2019 +0300"
  },
  "message": "SSL: removed logging of empty \"(SSL:)\" in ngx_ssl_error().\n\nThe \"(SSL:)\" snippet currently appears in logs when nginx code uses\nngx_ssl_error() to log an error, but OpenSSL\u0027s error queue is empty.\nThis can happen either because the error wasn\u0027t in fact from OpenSSL,\nor because OpenSSL did not indicate the error in the error queue\nfor some reason.\n\nIn particular, currently \"(SSL:)\" can be seen in errors at least in\nthe following cases:\n\n- When SSL_write() fails due to a syscall error,\n  \"[info] ... SSL_write() failed (SSL:) (32: Broken pipe)...\".\n\n- When loading a certificate with no data in it,\n  \"[emerg] PEM_read_bio_X509_AUX(...) failed (SSL:)\".\n  This can easily happen due to an additional empty line before\n  the end line, so all lines of the certificate are interpreted\n  as header lines.\n\n- When trying to configure an unknown curve,\n  \"[emerg] SSL_CTX_set1_curves_list(\"foo\") failed (SSL:)\".\n\nLikely there are other cases as well.\n\nWith this change, \"(SSL:...)\" will be only added to the error message\nif there is something in the error queue.  This is expected to make\nlogs more readable in the above cases.  Additionally, with this change\nit is now possible to use ngx_ssl_error() to log errors when some\nof the possible errors are not from OpenSSL and not expected to have\nanything in the error queue.\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "da06a6f8623fb29b8385db6af674793f3405fa17",
      "old_mode": 33188,
      "old_path": "src/event/ngx_event_openssl.c",
      "new_id": "569f5773101258cee187c864bd3a4a164aecded1",
      "new_mode": 33188,
      "new_path": "src/event/ngx_event_openssl.c"
    }
  ]
}