commit 181abe549fec2c93fb19a65beed2c6e73c8a7ce6
author Igor Sysoev <igor@sysoev.ru> Thu Dec 20 20:35:23 2007 +0000
committer Igor Sysoev <igor@sysoev.ru> Thu Dec 20 20:35:23 2007 +0000
tree 07ca595ef509e13fc404cac40585b303b74365ad
parent 0a0024bdb50f673ed79e1899501223c776fff665

embed session_rbtree and sentinel inside ngx_ssl_session_cache_t

src/event/ngx_event_openssl.c

diff --git a/src/event/ngx_event_openssl.c b/src/event/ngx_event_openssl.c
index 57fb3e8..ce65ccc 100644
--- a/src/event/ngx_event_openssl.c
+++ b/src/event/ngx_event_openssl.c
@@ -1217,7 +1217,6 @@
 ngx_ssl_session_cache_init(ngx_shm_zone_t *shm_zone, void *data)
 {
     ngx_slab_pool_t          *shpool;
-    ngx_rbtree_node_t        *sentinel;
     ngx_ssl_session_cache_t  *cache;
 
     if (data) {
@@ -1232,25 +1231,15 @@
         return NGX_ERROR;
     }
 
+    ngx_rbtree_init(&cache->session_rbtree, &cache->sentinel,
+                    ngx_ssl_session_rbtree_insert_value);
+
     cache->session_cache_head.prev = NULL;
     cache->session_cache_head.next = &cache->session_cache_tail;
 
     cache->session_cache_tail.prev = &cache->session_cache_head;
     cache->session_cache_tail.next = NULL;
 
-    cache->session_rbtree = ngx_slab_alloc(shpool, sizeof(ngx_rbtree_t));
-    if (cache->session_rbtree == NULL) {
-        return NGX_ERROR;
-    }
-
-    sentinel = ngx_slab_alloc(shpool, sizeof(ngx_rbtree_node_t));
-    if (sentinel == NULL) {
-        return NGX_ERROR;
-    }
-
-    ngx_rbtree_init(cache->session_rbtree, sentinel,
-                    ngx_ssl_session_rbtree_insert_value);
-
     shm_zone->data = cache;
 
     return NGX_OK;
@@ -1369,7 +1358,7 @@
     sess_id->prev = &cache->session_cache_head;
     cache->session_cache_head.next = sess_id;
 
-    ngx_rbtree_insert(cache->session_rbtree, &sess_id->node);
+    ngx_rbtree_insert(&cache->session_rbtree, &sess_id->node);
 
     ngx_shmtx_unlock(&shpool->mutex);
 
@@ -1432,8 +1421,8 @@
 
     ngx_shmtx_lock(&shpool->mutex);
 
-    node = cache->session_rbtree->root;
-    sentinel = cache->session_rbtree->sentinel;
+    node = cache->session_rbtree.root;
+    sentinel = cache->session_rbtree.sentinel;
 
     while (node != sentinel) {
 
@@ -1470,7 +1459,7 @@
                 sess_id->next->prev = sess_id->prev;
                 sess_id->prev->next = sess_id->next;
 
-                ngx_rbtree_delete(cache->session_rbtree, node);
+                ngx_rbtree_delete(&cache->session_rbtree, node);
 
                 ngx_slab_free_locked(shpool, sess_id->session);
 #if (NGX_PTR_SIZE == 4)
@@ -1527,8 +1516,8 @@
 
     ngx_shmtx_lock(&shpool->mutex);
 
-    node = cache->session_rbtree->root;
-    sentinel = cache->session_rbtree->sentinel;
+    node = cache->session_rbtree.root;
+    sentinel = cache->session_rbtree.sentinel;
 
     while (node != sentinel) {
 
@@ -1553,7 +1542,7 @@
                 sess_id->next->prev = sess_id->prev;
                 sess_id->prev->next = sess_id->next;
 
-                ngx_rbtree_delete(cache->session_rbtree, node);
+                ngx_rbtree_delete(&cache->session_rbtree, node);
 
                 ngx_slab_free_locked(shpool, sess_id->session);
 #if (NGX_PTR_SIZE == 4)
@@ -1601,7 +1590,7 @@
         sess_id->next->prev = sess_id->prev;
         sess_id->prev->next = sess_id->next;
 
-        ngx_rbtree_delete(cache->session_rbtree, &sess_id->node);
+        ngx_rbtree_delete(&cache->session_rbtree, &sess_id->node);
 
         ngx_log_debug1(NGX_LOG_DEBUG_EVENT, ngx_cycle->log, 0,
                        "expire session: %08Xi", sess_id->node.key);

src/event/ngx_event_openssl.h

diff --git a/src/event/ngx_event_openssl.h b/src/event/ngx_event_openssl.h
index 9e8ce17..504cc67 100644
--- a/src/event/ngx_event_openssl.h
+++ b/src/event/ngx_event_openssl.h
@@ -75,7 +75,8 @@
 
 
 typedef struct {
-    ngx_rbtree_t               *session_rbtree;
+    ngx_rbtree_t                session_rbtree;
+    ngx_rbtree_node_t           sentinel;
     ngx_ssl_sess_id_t           session_cache_head;
     ngx_ssl_sess_id_t           session_cache_tail;
 } ngx_ssl_session_cache_t;